Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release notes: 2025.01.2 #10007

Merged
merged 4 commits into from
Jan 31, 2025
Merged

release notes: 2025.01.2 #10007

merged 4 commits into from
Jan 31, 2025

Conversation

kmuehlbauer
Copy link
Contributor

@kmuehlbauer
Copy link
Contributor Author

Todo: fix contributors

@kmuehlbauer kmuehlbauer mentioned this pull request Jan 30, 2025
Copy link
Member

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This summary text looks good, but why are there no other entries in the whats-new? Have we become that sloppy at enforcing additions to the release notes in PRs?

@TomNicholas TomNicholas added the Release Planning and tracking progress of releases label Jan 30, 2025
@kmuehlbauer
Copy link
Contributor Author

This summary text looks good, but why are there no other entries in the whats-new? Have we become that sloppy at enforcing additions to the release notes in PRs?

I've checked the commit list and added one that was missing already. Several PR's (4 I think) are listed under the non-nanosecond new features entry. @TomNicholas which commits (which are not yet mentioned) should definitely be added to the whats-new?

@TomNicholas
Copy link
Member

Well I don't know about specific commits, but there are new features mentioned in the summary text that don't have whats-new entries, e.g.

suggestion of correct names when trying to access non-existent data variables

@TomNicholas
Copy link
Member

TomNicholas commented Jan 30, 2025

To be clear I'm not asking you to go back and fish through and add them, but I do think we should be trying harder to actually document all changes as we merge PRs. (Or better yet, have some automated enforcement.)

@kmuehlbauer
Copy link
Contributor Author

Well I don't know about specific commits, but there are new features mentioned in the summary text that don't have whats-new entries, e.g.

suggestion of correct names when trying to access non-existent data variables

That's that one here:

Improve the error message raised when no key is matching the available variables in a dataset. (:pull:9943) By Jimmy Westling.

I've taken the description of the PR instead because it gets better to the point.

@kmuehlbauer kmuehlbauer merged commit d8d1d9e into pydata:main Jan 31, 2025
29 checks passed
@kmuehlbauer kmuehlbauer deleted the rel-2025.1.2 branch January 31, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Planning and tracking progress of releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 2025.01.2
3 participants